Support absolute paths in BOWER_COMPONENT_ROOT & tox (testing) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything you need from me to get this merged? |
|
Sorry, haven't done any python development in a while. Looks good, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a problem deploying a packaged Flask application and adds tox for testing against multiple Python versions.
The
current_app.root_pathpath ends up being something like/$VIRTUALENV/lib/python3.6/site-packages/$APPLICATION. Because the existing path search does a simple'/'.join(paths), with the first path beingcurrent_app.root_path, Flask-Bower does not work with a BOWER_COMPONENT_ROOT located above the installed path of the application.To remedy this problem, I've changed the path generation to use
os.path.join. This allows passing explicit paths while retaining the existing behavior. Additionally, it should enable Flask-Bower to work on platforms that use a separator other than '/'.